feat: save table filters in local storage #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces persistence of table filters using local storage and updates related test configurations to align with new import paths and helper functions.
- Added
useTableFiltershook and updateduseColumnFiltersto use local storage - Updated test configs (Vite and TSConfig) with new path aliases and imports
- Refactored filter and table components (
RangeSliderFilter,LlamaMarketsTable) to use the new hooks
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/vite.config.ts | Added resolve aliases for UI, kits, and APIs |
| tests/tsconfig.json | Configured path mappings for package imports |
| tests/cypress/tsconfig.json | Extended path mappings for Cypress tests |
| tests/cypress/support/helpers/lending-mocks.ts | Updated API imports and utilization calculation in mocks |
| tests/cypress/e2e/llamalend/llamalend-markets.cy.ts | Wrapped tests in a loop, refactored expandRowOnMobile helper, and updated selectors |
| packages/tsconfig/cypress.json | Switched moduleResolution to bundler |
| packages/curve-ui-kit/src/shared/ui/DataTable/TableFilters.tsx | Imported useTableFilters, removed unused useState, and changed useColumnFilters signature |
| packages/curve-ui-kit/src/hooks/useLocalStorage.ts | Introduced useTableFilters hook |
| apps/main/src/llamalend/PageLlamaMarkets/filters/RangeSliderFilter.tsx | Adjusted range filter logic and hook dependencies |
| apps/main/src/llamalend/PageLlamaMarkets/LlamaMarketsTable.tsx | Added TITLE constant and updated useColumnFilters usage |
Comments suppressed due to low confidence (2)
packages/curve-ui-kit/src/shared/ui/DataTable/TableFilters.tsx:144
- [nitpick] The doc comment for
useColumnFiltersis outdated after changing the signature to accepttableTitle. Update the comment to explain the purpose of thetableTitleparameter and how filters are persisted.
*/
apps/main/src/llamalend/PageLlamaMarkets/filters/RangeSliderFilter.tsx:60
- [nitpick] Verify that
maxValuematches the intended default maximum value (e.g.,defaultValue[1]or adefaultMaximumprop). Inconsistent naming betweendefaultValueandmaxValuecan cause confusion or incorrect behavior.
: [newRange[0] === defaultMinimum ? null : newRange[0], newRange[1] === maxValue ? null : newRange[1]],
0xAlunara
approved these changes
Jul 16, 2025
Right I didn't include this in the scope, I'll create a separate task |
0xtutti
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.